fix ade7758

components/evse/evse_core.c

@@ -1,4 +1,4 @@
-// evse_core.c - Função principal de controle do EVSE
+// evse_core.c - Main EVSE control logic
 
 #include "evse_fsm.h"
 #include "evse_error.h"
@@ -13,23 +13,30 @@
 static const char *TAG = "evse_core";
 
 static SemaphoreHandle_t mutex;
-
 static evse_state_t last_state = EVSE_STATE_A;
 
 static void evse_core_task(void *arg);
 
+// ================================
+// Initialization
+// ================================
+
 void evse_init(void) {
     ESP_LOGI(TAG, "EVSE Init");
 
-    mutex = xSemaphoreCreateMutex();
+    mutex = xSemaphoreCreateMutex();  // Optional: use static version for deterministic memory
 
     evse_check_defaults();
     evse_fsm_reset();
-    pilot_set_level(true);  // Estado inicial do piloto
+    pilot_set_level(true);  // Enable pilot output
 
     xTaskCreate(evse_core_task, "evse_core_task", 4096, NULL, 5, NULL);
 }
 
+// ================================
+// Main Processing Logic
+// ================================
+
 void evse_process(void) {
     xSemaphoreTake(mutex, portMAX_DELAY);
 
@@ -39,42 +46,36 @@ void evse_process(void) {
     pilot_measure(&pilot_voltage, &is_n12v);
     ESP_LOGD(TAG, "Pilot: %d, -12V: %s", pilot_voltage, is_n12v ? "yes" : "no");
 
-    if (evse_get_error() == 0 && !evse_is_error_cleared()) {
+    evse_error_check(pilot_voltage, is_n12v);
 
-        evse_error_check(pilot_voltage, is_n12v);
+    // Só chama FSM, que decide tudo
+    evse_fsm_process(
+        pilot_voltage,
+        evse_state_get_authorized(),
+        evse_config_is_available(),
+        evse_config_is_enabled()
+    );
 
-        evse_fsm_process(
-            pilot_voltage,
-            evse_state_get_authorized(),
-            evse_config_is_available(),
-            evse_config_is_enabled()
-        );
+    evse_limits_check();
 
-        evse_limits_check();
-
-        evse_state_t current = evse_get_state();
-        if (current != last_state) {
-            ESP_LOGI(TAG, "State changed: %s → %s",
-                     evse_state_to_str(last_state),
-                     evse_state_to_str(current));
-            last_state = current;
-        }
-
-        evse_mark_error_cleared();
+    evse_state_t current = evse_get_state();
+    if (current != last_state) {
+        ESP_LOGI(TAG, "State changed: %s → %s",
+                 evse_state_to_str(last_state),
+                 evse_state_to_str(current));
+        last_state = current;
     }
 
+    evse_mark_error_cleared();
+
     xSemaphoreGive(mutex);
 }
 
 
 // ================================
-// Interface pública
+// Public Configuration Interface
 // ================================
 
-bool evse_is_enabled(void) {
-    return evse_config_is_enabled();
-}
-
 void evse_set_enabled(bool value) {
     ESP_LOGI(TAG, "Set enabled %d", value);
     evse_config_set_enabled(value);
@@ -90,21 +91,12 @@ void evse_set_available(bool value) {
 }
 
 // ================================
-// Tarefa principal
+// Background Task
 // ================================
 
 static void evse_core_task(void *arg) {
     while (true) {
         evse_process();
-        vTaskDelay(pdMS_TO_TICKS(100));
+        vTaskDelay(pdMS_TO_TICKS(100));  // 10 Hz cycle
     }
-}
-
-uint32_t evse_get_total_energy(void) {
-    return 0; // Stub de 1 kWh
-}
-
-uint32_t evse_get_instant_power(void) {
-    return 0; // Stub de 2 kW
-}
-
+}